Re: new heapcheck contrib module

Mark Dilger <mark.dilger@enterprisedb.com>

From: Mark Dilger <mark.dilger@enterprisedb.com>

To: Amul Sul <sulamul@gmail.com>

Cc: Robert Haas <robertmhaas@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Peter Geoghegan <pg@bowt.ie>, Andres Freund <andres@anarazel.de>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2020-07-22T00:47:12Z

Lists: pgsql-hackers

Attachments

v12-0001-Adding-function-verify_btreeam-and-bumping-versi.patch (application/octet-stream) patch v12-0001
v12-0002-Adding-function-verify_heapam-to-amcheck-module.patch (application/octet-stream) patch v12-0002
v12-0003-Adding-contrib-module-pg_amcheck.patch (application/octet-stream) patch v12-0003
(unnamed) (text/plain)


> On Jul 20, 2020, at 11:50 PM, Amul Sul <sulamul@gmail.com> wrote:
> 
> On Tue, Jul 21, 2020 at 10:58 AM Amul Sul <sulamul@gmail.com> wrote:
>> 
>> Hi Mark,
>> 
>> I think new structures should be listed in src/tools/pgindent/typedefs.list,
>> otherwise, pgindent might disturb its indentation.
>> 

<snip>

> 
> In v11-0001 and v11-0002 patches, there are still a few more errmsg that need to
> be joined.
> 
> e.g:
> 
> + /* check to see if caller supports us returning a tuplestore */
> + if (rsinfo == NULL || !IsA(rsinfo, ReturnSetInfo))
> + ereport(ERROR,
> + (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
> + errmsg("set-valued function called in context that cannot "
> + "accept a set")));
> + if (!(rsinfo->allowedModes & SFRM_Materialize))
> + ereport(ERROR,
> + (errcode(ERRCODE_SYNTAX_ERROR),
> + errmsg("materialize mode required, but it is not allowed "
> + "in this context")));

Thanks for the review!

I believe these v12 patches resolve the two issues you raised.

Commits

Add pg_amcheck, a CLI for contrib/amcheck.
- 9706092839db 14.0 landed
Refactor and generalize the ParallelSlot machinery.
- f71519e545a3 14.0 landed
Generalize parallel slot result handling.
- 418611c84d00 14.0 landed
Move some code from src/bin/scripts to src/fe_utils to permit reuse.
- e955bd4b6c2b 14.0 landed
Factor pattern-construction logic out of processSQLNamePattern.
- 2c8726c4b0a4 14.0 landed
Doc: clean up verify_heapam() documentation.
- 4c49d8fc15ee 14.0 landed
Fix more portability issues in new amcheck code.
- 321633e17b07 14.0 landed
Fix portability issues in new amcheck test.
- 860593ec3bd1 14.0 landed
Try to avoid a compiler warning about using fxid uninitialized.
- 8bb0c9770e80 14.0 landed
Extend amcheck to check heap pages.
- 866e24d47db1 14.0 landed
Adjust walsender usage of xlogreader, simplify APIs
- 850196b610d2 13.0 cited
Improve checking of child pages in contrib/amcheck.
- d114cc538715 13.0 cited
Sanitize line pointers within contrib/amcheck.
- a9ce839a3137 12.0 cited
Fix possible sorting error when aborting use of abbreviated keys.
- 008c4135ccf6 10.0 cited