Re: Yet another fast GiST build (typo)

x4mmm@yandex-team.ru

From: "Andrey M. Borodin" <x4mmm@yandex-team.ru>

To: Thomas Munro <thomas.munro@gmail.com>

Cc: Daniel Gustafsson <daniel@yesql.se>, Erik Rijkers <er@xs4all.nl>, Michael Paquier <michael@paquier.xyz>, Alexander Korotkov <a.korotkov@postgrespro.ru>, Darafei Komяpa Praliaskouski <me@komzpa.net>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2020-08-04T17:28:22Z

Lists: pgsql-hackers

Attachments

v10-0001-Add-sort-support-for-point-gist_point_sortsuppor.patch (application/octet-stream) patch v10-0001
v10-0002-Implement-GiST-build-using-sort-support.patch (application/octet-stream) patch v10-0002


> 30 июля 2020 г., в 06:26, Thomas Munro <thomas.munro@gmail.com> написал(а):
> 
> On Fri, Jul 10, 2020 at 6:55 PM Andrey M. Borodin <x4mmm@yandex-team.ru> wrote:
>> Thanks! Fixed.
> 
> It's not a bug, but I think those 64 bit constants should be wrapped
> in UINT64CONST(), following our convention.
Thanks, fixed!

> I'm confused about these two patches: 0001 introduces
> gist_point_fastcmp(), but then 0002 changes it to gist_bbox_fastcmp().
> Maybe you intended to keep both of them?  Also 0002 seems to have
> fixups for 0001 squashed into it.
Indeed, that were fixups: point converted to GiST representation is a bbox already, and the function expects only bboxes.

Also I've fixed some mismerges in documentation.

Thanks!

Best regards, Andrey Borodin.

Commits

Add sortsupport for gist_btree opclasses, for faster index builds.
- 9f984ba6d23d 14.0 landed
pageinspect: Fix relcache leak in gist_page_items().
- 04eb75e783ba 14.0 landed
Fix test failure with wal_level=minimal.
- 5abca4b1cd71 14.0 landed
Enhance nbtree index tuple deletion.
- d168b666823b 14.0 cited
Fix portability issues in the new gist pageinspect test.
- 6ecaaf810b8b 14.0 landed
Add functions to 'pageinspect' to inspect GiST indexes.
- 756ab29124d7 14.0 landed
Fix missing validation for the new GiST sortsupport functions.
- 6f0bc5e1daf0 14.0 landed
Fix compilation warning in xlog.c
- 0a3c864c3275 14.0 cited
Set right-links during sorted GiST index build.
- 265ea567852a 14.0 landed
Fix checksum calculation in the new sorting GiST build.
- c47a240fe6db 14.0 landed
Add support for building GiST index by sorting.
- 16fa9b2b30a3 14.0 landed