Re: Additional message in pg_terminate_backend

Andrey Borodin <x4mmm@yandex-team.ru>

From: Andrey Borodin <x4mmm@yandex-team.ru>

To: Roman Khapov <rkhapov@yandex-team.ru>

Cc: Jim Jones <jim.jones@uni-muenster.de>, Kirill Reshke <reshkekirill@gmail.com>, Daniel Gustafsson <daniel@yesql.se>, pgsql-hackers@lists.postgresql.org

Date: 2026-02-03T08:26:43Z

Lists: pgsql-hackers


> On 3 Feb 2026, at 12:52, Roman Khapov <rkhapov@yandex-team.ru> wrote:
> 
> <v4-0001-message-in-pg_terminate_backend-and-pg_cancel_bac.patch>

Some notes on this version:

1. Did you mean BackendMsgShmemSize()?
    size = add_size(size, BackendStatusShmemSize());

2. In docs: 

<function>pg_cancel_backend</function> ( <parameter>pid</parameter> <type>integer</type>, <parameter>message</parameter> <type>test</type> <literal>DEFAULT</literal> <literal>''</literal> )

Did you mean <type>text</type>?

3. Windows build failed [0]

4. In src/include/utils/misc/backend_msg.c identification is backend_msg.h


Best regards, Andrey Borodin.

[0] https://github.com/x4m/postgres_g/runs/62314358734