Horton

Re: pg_basebackup's --gzip switch misbehaves

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>, pgsql-hackers@lists.postgresql.org
Date: 2022-09-14T08:26:42Z
Lists: pgsql-hackers 
> On 13 Sep 2022, at 23:38, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> The $tempdir is some temporary subdirectory of tmp_check that will get nuked at
> the end of the TAP test no matter what.  So these rmtrees are merely making the
> evidence disappear a bit faster; it will anyway.


Maybe the creation of $tempdir should take PG_TEST_NOCLEAN into account and not
register CLEANUP if set?

--
Daniel Gustafsson		https://vmware.com/

Commits

  1. Make PG_TEST_NOCLEAN work for temporary directories in TAP tests

  2. doc: document the TAP test environment variables

  3. doc: update metacpan.org links to avoid redirects

  4. Use min/max bounds defined by Zstd for compression level

  5. Fix incorrect value for "strategy" with deflateParams() in walmethods.c

  6. Simplify handling of compression level with compression specifications