Re: Online enabling of checksums
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: Sergei Kornilov <sk@zsrv.org>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>,
Magnus Hagander <magnus@hagander.net>
Date: 2018-07-25T09:35:31Z
Lists: pgsql-hackers
Attachments
- online_checksums13.patch (application/octet-stream) patch
> On 24 Jul 2018, at 11:05, Sergei Kornilov <sk@zsrv.org> wrote: > > The following review has been posted through the commitfest application: > make installcheck-world: tested, failed > Implements feature: not tested > Spec compliant: not tested > Documentation: tested, failed > > Hello > As i wrote few weeks ago i can not build documentation due errors: >> postgres.sgml:19625: element xref: validity error : IDREF attribute linkend references an unknown ID "runtime-checksumhelper-cost-delay" >> postgres.sgml:19626: element xref: validity error : IDREF attribute linkend references an unknown ID "runtime-checksumhelper-cost-limit" > > After remove such xref for test purposes patch pass check-world. Hi!, Thanks for reviewing, I’ve updated the patch with the above mentioned incorrect linkends as well as fixed the comments you made in a previous review. The CF-builder-bot is red, but it’s because it’s trying to apply the already committed patch which is in the attached datallowconn thread. cheers ./daniel
Commits
-
Online enabling and disabling of data checksums
- f19c0eccae96 19 (unreleased) landed
-
Deactive flapping checksum isolation tests.
- bf75fe47e444 11.0 landed
-
Add support for coordinating record typmods among parallel workers.
- cc5f81366c36 11.0 cited