Re: tableam: abstracting relation sizing code

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>
To: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-06-11T22:22:56Z
Lists: pgsql-hackers
> On 10 Jun 2019, at 21:35, Robert Haas <robertmhaas@gmail.com> wrote:
> 
> On Fri, Jun 7, 2019 at 6:42 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>>> Good catch, and now I notice that the callback is not called
>>> estimate_rel_size but relation_estimate_size.  Updated patch attached;
>>> thanks for the review.
>> 
>> The commit message still refers to it as estimate_rel_size though. The comment on
>> table_block_relation_estimate_size does too but that one might be intentional.
> 
> Oops.  New version attached, hopefully fixing those and the compiler
> warning Alvaro noted.

+1 on this version of the patch, no warning, passes tests and looks good.

cheers ./daniel


Commits

  1. tableam: Provide helper functions for relation sizing.