Re: Logging corruption error codes
x4mmm@yandex-team.ru
From: Andrey Borodin <x4mmm@yandex-team.ru>
To: Michael Paquier <michael@paquier.xyz>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, pgsql-bugs@lists.postgresql.org, Анна Крханбарова <annkpx@yandex-team.ru>, Dmitriy Sarafannikov <dsarafan@yandex-team.ru>
Date: 2019-06-25T10:01:23Z
Lists: pgsql-bugs
Hi Michael! > 24 июня 2019 г., в 6:59, Michael Paquier <michael@paquier.xyz> написал(а): >> If we introduce new error code - this is, kind of, new >> feature. Should I send it to pgsql-hackers? > > Yes, I don't think that new error codes would gain a back-patch. > So discussing that on -hackers would be more adapted in my opinion. > > Looking at the patch you propose, I don't have an argument against > applying what you propose FWIW. These suggestions seem sensible. But > that's not really a bug as the code works properly even without your > changes. Ok, if it's not a bug, should I re-send it to pgsql-hackers@ ? Or just register on CF as a new thing... > > Note: the indentation of the patch is incorrect everywhere. A > committer applying your patch would apply pgindent anyway. :) Oh, sorry. I'm trying to write "like a code around", but do not understand clearly how pgindent formats... Best regards, Andrey Borodin.
Commits
-
Add error codes to some corruption log messages
- fd6ec93bf890 13.0 landed