Re: [HACKERS] Interval aggregate regression failure (expected seems

Michael Glaesemann <grzm@seespotcode.net>

From: Michael Glaesemann <grzm@seespotcode.net>
To: Michael Glaesemann <grzm@seespotcode.net>
Cc: Bruce Momjian <bruce@momjian.us>, Tom Lane <tgl@sss.pgh.pa.us>, Michael Paesold <mpaesold@gmx.at>, PostgreSQL-patches <pgsql-patches@postgresql.org>
Date: 2006-08-29T15:02:41Z
Lists: pgsql-hackers

Attachments

On Aug 29, 2006, at 15:38 , Michael Glaesemann wrote:

> I think I've got it. I plan to update the regression tests this  
> evening, but I wanted to post what I believe is a solution.

I've cleaned up the patch a bit in terms of whitespace, comments, and  
parens. I've also updated the interval and horology regression tests.  
The horology tests needed updating because I added 5 rows to  
INTERVAL_TBL. I didn't check the math for every row of time(tz |  
stamp | stamptz)/interval arithmetic in the horology tests as I think  
problems in this area would have shown up before. Does that make  
sense or it just rationalization on my part?

Both with and without --enable-integer-datetimes pass the regression  
tests.

Thanks!

Michael Glaesemann
grzm seespotcode net