Horton

Re: Some code cleanup for pgbench and pg_verifybackup

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Michael Paquier <michael@paquier.xyz>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Fabien COELHO <coelho@cri.ensmp.fr>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-07-27T11:02:34Z
Lists: pgsql-hackers 
> On 27 Jul 2021, at 01:53, Michael Paquier <michael@paquier.xyz> wrote:

> ..and I also recall that this point has been discussed, where the conclusion
> was that the logging should never exit() directly.


That's a characteristic of the API which still holds IMO.  If we want
something, it's better to have an explicit exit function which takes a log
string than a log function that exits.

--
Daniel Gustafsson		https://vmware.com/

Commits

  1. Add some missing exit() calls in error paths for various binaries

  2. Add missing exit() in pg_verifybackup when failing to find pg_waldump