Horton

Re: [HACKERS] PATCH: multivariate histograms and MCV lists

Mark Dilger <hornschnorter@gmail.com>

View thread View on postgr.es
From: Mark Dilger <hornschnorter@gmail.com>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Adrien Nayrat <adrien.nayrat@dalibo.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2017-12-20T01:44:57Z
Lists: pgsql-hackers 
> On Dec 19, 2017, at 4:31 PM, Tomas Vondra <tomas.vondra@2ndquadrant.com> wrote:
> 
> Hi,
> 
> On 12/19/2017 08:17 PM, Mark Dilger wrote:
>> 
>> I tested your latest patches on my mac os x laptop and got one test
>> failure due to the results of 'explain' coming up differently.  For the record,
>> I followed these steps:
>> 
>> cd postgresql/
>> git pull
>> # this got my directory up to 8526bcb2df76d5171b4f4d6dc7a97560a73a5eff with no local changes
>> patch -p 1 < ../0001-multivariate-MCV-lists.patch
>> patch -p 1 < ../0002-multivariate-histograms.patch
>> ./configure --prefix=/Users/mark/master/testinstall --enable-cassert --enable-tap-tests --enable-depend && make -j4 && make check-world
>> 
> 
> Yeah, those steps sounds about right.
> 
> Apparently this got broken by ecc27d55f4, although I don't quite
> understand why - but it works fine before. Can you try if it works fine
> on 9f4992e2a9 and fails with ecc27d55f4?

It succeeds with 9f4992e2a9.  It fails with ecc27d55f4.  The failures look
to be the same as I reported previously.

mark

Commits

  1. Convert pre-existing stats_ext tests to new style

  2. Add support for multivariate MCV lists

  3. Improve ANALYZE's strategy for finding MCVs.

  4. Clone extended stats in CREATE TABLE (LIKE INCLUDING ALL)

  5. Try again to fix accumulation of parallel worker instrumentation.

  6. Adjust psql \d query to avoid use of @> operator.

  7. Message style fixes

  8. Add security checks to selectivity estimation functions