Re: "openssl" should not be optional

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>

To: Christoph Berg <myon@debian.org>

Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-09-24T11:40:22Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Avoid warnings in tests when openssl binary isn't available
- f01c4eb4e901 17.7 landed
- bf5b26525b28 16.11 landed
- 7d129ba54e74 19 (unreleased) landed
- 150a1b328778 18.1 landed

> On 24 Sep 2025, at 13:37, Christoph Berg <myon@debian.org> wrote:
> 
> Re: Daniel Gustafsson
>> It seems a bit restrictive to require the openssl binary which is test-only,
>> since we allow building with ssl but without TAP support (which is where the
>> openssl binary is used).
> 
> Ok, but then the error messages should be better. This was found
> because a fellow Debian developer was smart enough to spot the extra
> space in that " x509" error message... (And another one knew about
> this difference between the different build environments.)

If we make it optional and skip the relevant tests then there wouldn't be any
errors messages?  I do agree that all messaging around should be very clear
though, so it's obvious why tests were skipped.

Do you feel like expanding your patch or should I?

--
Daniel Gustafsson