Re: GiST VACUUM

x4mmm@yandex-team.ru

From: Andrey Borodin <x4mmm@yandex-team.ru>

To: Heikki Linnakangas <hlinnaka@iki.fi>

Cc: Michael Paquier <michael@paquier.xyz>, Thomas Munro <thomas.munro@enterprisedb.com>, Robert Haas <robertmhaas@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, Костя Кузнецов <chapaev28@ya.ru>

Date: 2019-01-03T18:47:13Z

Lists: pgsql-hackers

Attachments

0002-Test-left-jumps-v18.patch (application/octet-stream) patch v18-0002
0001-Physical-GiST-scan-in-VACUUM-v18-with-test-modificat.patch (application/octet-stream) patch v18-0001
(unnamed) (text/plain)
0002-Delete-pages-during-GiST-VACUUM-v19.patch (application/octet-stream) patch v19-0002
0001-Physical-GiST-scan-in-VACUUM-v19.patch (application/octet-stream) patch v19-0001

Cool, thanks!

> 2 янв. 2019 г., в 20:35, Heikki Linnakangas <hlinnaka@iki.fi> написал(а):
> 
> In patch #1, to do the vacuum scan in physical order:
> ...
> I think this is ready to be committed, except that I didn't do any testing. We discussed the need for testing earlier. Did you write some test scripts for this, or how have you been testing?
Please see test I used to check left jumps for v18:
0001-Physical-GiST-scan-in-VACUUM-v18-with-test-modificat.patch
0002-Test-left-jumps-v18.patch

Commits

Use full 64-bit XID for checking if a deleted GiST page is old enough.
- fb5344c969af 12.0 landed
- 6655a7299d83 13.0 landed
Refactor checks for deleted GiST pages.
- e2e992c93145 12.0 landed
- 9eb5607e6993 13.0 landed
Delete empty pages during GiST VACUUM.
- 7df159a620b7 12.0 landed
Scan GiST indexes in physical order during VACUUM.
- fe280694d0d4 12.0 landed
Prevent GIN deleted pages from being reclaimed too early
- 52ac6cd2d0cd 12.0 cited