Horton

Re: Windows: openssl & gssapi dislike each other

Daniel Gustafsson <daniel@yesql.se>

View thread
From: Daniel Gustafsson <daniel@yesql.se>
To: vignesh C <vignesh21@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Andrew Dunstan <andrew@dunslane.net>, Dave Page <dpage@pgadmin.org>, Imran Zaheer <imran.zhir@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2025-03-26T14:47:21Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Move GSSAPI includes into its own header

  2. Tighten test_predtest's input checks, and improve error messages.

  3. Collation documentation fixes.

  4. contrib/sslinfo needs a fix too to make hamerkop happy.

  5. Second attempt to silence SSL compile failures on hamerkop.

> On 26 Mar 2025, at 09:53, vignesh C <vignesh21@gmail.com> wrote:
> On Fri, 31 Jan 2025 at 21:05, Daniel Gustafsson <daniel@yesql.se> wrote:
>> 
>>> On 31 Jan 2025, at 16:29, Andres Freund <andres@anarazel.de> wrote:

>>> This #ifdef ENABLE_GSS probably isn't necessary anymore.
>> 
>> Yeah, I only left it for code documentation reasons to keep readers from
>> thinking the ifdef was missing and had to go chase it in the new file.  It's
>> definitely not required though I for sure don't mind removing it if others feel
>> it's pointless.
> 
> Few thoughts:
> 1) I also felt that this could be removed.

Fixed.

> 2) Was the copyright year retained as 1996 intentionally for the new
> "pg-gssapi.h" file added because the contents were copied from other
> files?
> + * Portions Copyright (c) 1996-2025, PostgreSQL Global Development Group
> + * Portions Copyright (c) 1994, Regents of the University of California
> 
> I see in few other places were new file was created, it was mentioned
> as "Copyright (c) 2025, PostgreSQL Global Development Group"

Right, this is new file but not net-new content so I retained the copyright
from the original location. We are standing on the shoulders of giants.

> 3) Apart from that, there was a small whitespace issue while applying the patch:
> git am v1-0001-Move-GSSAPI-includes-into-its-own-header.patch
> Applying: Move GSSAPI includes into its own header
> .git/rebase-apply/patch:116: new blank line at EOF.
> +
> warning: 1 line adds whitespace errors.

Fixed.

> Overall patch looks good to me.

Thanks for review!  Pushed after making the above changes and taking it for
another CI run.

--
Daniel Gustafsson