Thread

Re: [PATCH v1] replindex: Fix comment grammar in build_replindex_scan_key()

Chao Li <li.evan.chao@gmail.com> — 2025-12-29T22:33:18Z

> On Dec 29, 2025, at 16:20, zourenli <398740848@qq.com> wrote:
> 
> Hi all, 
> 
> This is a trivial grammar fix for the comment of build_replindex_scan_key() function in replindex.c. 
> Two missing indefinite articles 'a' are added to make the comment grammatically correct. 
> No functional changes are involved. 
> 
> Patch is attached below. 
> 
> Thanks, 
> zourenli 
> <398740848@qq.com> 
> 
> 
> 
> <v1-0001-corrects-minor-grammatical-issues-in-comment-of-b.patch>

Both fixes look unambiguously correct to me:

    • “This is not generic routine” -> “This is not a generic routine”
    • “used for REPLICA IDENTITY FULL table” -> “used for a REPLICA IDENTITY FULL table”

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/