Re: BUG #17212: pg_amcheck fails on checking temporary relations

Mark Dilger <mark.dilger@enterprisedb.com>

From: Mark Dilger <mark.dilger@enterprisedb.com>

To: Peter Geoghegan <pg@bowt.ie>

Cc: Alexander Lakhin <exclusion@gmail.com>, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>, Robert Haas <robertmhaas@gmail.com>

Date: 2021-10-03T17:04:19Z

Lists: pgsql-bugs, pgsql-hackers

Attachments

v1-0001-Bug-fix-do-not-check-temp-tables-from-pg_amcheck.patch (application/octet-stream) patch v1-0001
(unnamed) (text/plain)

> On Oct 2, 2021, at 10:32 AM, Peter Geoghegan <pg@bowt.ie> wrote:
> 
> On Sat, Oct 2, 2021 at 4:49 AM PG Bug reporting form
> <noreply@postgresql.org> wrote:
>> Although you can add --exclude-relation=*.pg_temp*.*, this behaviour differs
>> from the behaviour of pg_dump and friends, which skip such relations
>> silently.
> 
> I agree -- this behavior is a bug.
> 
> Can you propose a fix, Mark?

The attached patch includes a test case for this, which shows the problems against the current pg_amcheck.c, and a new version of pg_amcheck.c which fixes the bug.  Could you review it?

Thanks for bringing this to my attention.

Commits

Remove unstable pg_amcheck tests.
- cd3f429d9565 15.0 landed
- 5863115e4cb1 14.1 landed
pg_amcheck: avoid unhelpful verification attempts.
- d2bf06db3779 15.0 landed
- dd58194cf563 14.1 landed
amcheck: Skip unlogged relations in Hot Standby.
- 292698f158dd 15.0 landed
- e7712155ea08 14.1 landed
amcheck: Skip unlogged relations during recovery.
- 6754fe65a4c6 13.0 cited