Re: pg_upgrade: Improve invalid option handling
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>,
pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2019-06-19T20:42:54Z
Lists: pgsql-hackers
> On 19 Jun 2019, at 21:51, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote: > > On 2019-06-19 04:24, Michael Paquier wrote: >> On Tue, Jun 18, 2019 at 10:25:44AM +0200, Daniel Gustafsson wrote: >>> Correct, that matches how pg_basebackup and psql does it. >> >> Perhaps you have a patch at hand? I can see four strings in >> pg_upgrade, two in exec.c and two in option.c, which could be >> improved. > > Committed my patch and the fixes for those error messages. Looks good, thanks! cheers ./daniel
Commits
-
pg_upgrade: Improve error messages
- cd917ffb9a43 12.0 landed
-
pg_upgrade: Improve invalid option handling
- aba78ab4a950 12.0 landed