Horton

Re: BUG #17391: While using --with-ssl=openssl and PG_TEST_EXTRA='ssl' options, SSL tests fail on OpenBSD 7.0

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@gmail.com>, Andres Freund <andres@anarazel.de>, byavuz81@gmail.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>, Heikki Linnakangas <heikki.linnakangas@iki.fi>, Michael Paquier <michael@paquier.xyz>
Date: 2022-02-03T15:48:40Z
Lists: pgsql-bugs 
Pouring over SSL test logs I was again red-herringed by the warning we get for
using hex() on a large input value, before I remembered that it's benign and
emerged from the rabbithole:

  Hexadecimal number > 0xffffffff non-portable at t/001_ssltests.pl line 508.

We could suppress it by turning off warnings for that line, since we know it
will work due to the 64-bit int test a few lines before:

@@ -505,6 +505,7 @@ if ($? == 0)
        {
                $serialno =~ s/^serial=//;
                $serialno =~ s/\s+//g;
+               local $SIG{'__WARN__'} = sub { };
                $serialno = hex($serialno);
        }
        else

Turning of warnings might be a bridge too far for some though? Thoughts?

--
Daniel Gustafsson		https://vmware.com/

Commits

  1. Move libpq's write_failed mechanism down to pqsecure_raw_write().

  2. Fix thinko in PQisBusy().

  3. Set SNI ClientHello extension to localhost in tests

  4. Improve worst-case performance of text_position_get_match_pos()