Horton

Re: BUG #14941: Vacuum crashes

Nathan Bossart <bossartn@amazon.com>

View thread View on postgr.es
From: "Bossart, Nathan" <bossartn@amazon.com>
To: Michael Paquier <michael.paquier@gmail.com>, Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Lyes Ameddah <lyes.amd@gmail.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, "pgsql-bugs@postgresql.org" <pgsql-bugs@postgresql.org>
Date: 2018-01-10T17:30:18Z
Lists: pgsql-bugs, pgsql-hackers 
On 1/9/18, 8:55 PM, "Michael Paquier" <michael.paquier@gmail.com> wrote:
> On Tue, Jan 09, 2018 at 01:46:55PM -0800, Andres Freund wrote:
>> On 2018-01-09 10:23:12 -0500, Robert Haas wrote:
>> > On Mon, Jan 8, 2018 at 11:27 PM, Michael Paquier
>> > <michael.paquier@gmail.com> wrote:
>> > > On Thu, Dec 28, 2017 at 10:46:18PM +0000, Bossart, Nathan wrote:
>> > >> I agree, this makes more sense.  I've made this change in v3 of 0003.
>> > >
>> > > Based on the opinions gathered on this thread, 0001 and 0002 seem to be
>> > > in the shape wanted, and those look good for shipping.
>> > 
>> > Committed 0001.
>> 
>> FWIW, I think in the future it'd be good to develop new features outside
>> of a thread about "vacuum crashes".
>
> You are right atht this is bad practice. Partially my fault for not
> recommending the move to a new thread.

Yes, sorry about that.  I should have opened a new thread.

Nathan

Commits

  1. Add option SKIP_LOCKED to VACUUM and ANALYZE

  2. Rename VACOPT_NOWAIT to VACOPT_SKIP_LOCKED

  3. Add parenthesized options syntax for ANALYZE.

  4. Don't allow VACUUM VERBOSE ANALYZE VERBOSE.

  5. Fix inadequate locking during get_rel_oids().

  6. Avoid having autovacuum workers wait for relation locks.