Horton

Re: pgsql: Add 'basebackup_to_shell' contrib module.

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Andrew Dunstan <andrew@dunslane.net>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Magnus Hagander <magnus@hagander.net>
Date: 2022-03-26T20:09:44Z
Lists: pgsql-hackers 
> On 26 Mar 2022, at 21:03, Robert Haas <robertmhaas@gmail.com> wrote:
> 
> On Sat, Mar 26, 2022 at 3:35 PM Andres Freund <andres@anarazel.de> wrote:
>> === tap tests in src/bin/pg_resetwal ===
>> t/001_basic.pl ...... ok
>> t/002_corrupted.pl .. ok
>> All tests successful.
>> Files=2, Tests=18,  3 wallclock secs ( 0.01 usr  0.01 sys +  2.39 cusr  0.31 csys =  2.72 CPU)
>> Result: PASS
>> === tap tests in src/bin/pg_checksums ===
>> t/001_basic.pl .... ok
>> t/002_actions.pl .. ok
>> All tests successful.
>> Files=2, Tests=74,  4 wallclock secs ( 0.02 usr  0.01 sys +  1.57 cusr  0.42 csys =  2.02 CPU)
>> Result: PASS
> 
> Yeah, this certainly seems like an improvement to me.

+1, that's clearly better.

--
Daniel Gustafsson		https://vmware.com/

Commits

  1. Print information about type of test and subdirectory before running tests.

  2. In basebackup_to_shell tests, properly set up pg_hba.conf.

  3. Add .gitignore for basebackup_to_shell.

  4. basebackup_to_shell: Add TAP test.

  5. Document basebackup_to_shell.required_role.

  6. Add 'basebackup_to_shell' contrib module.