Horton

Re: Fix error handling in be_tls_open_server()

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Sergey Shinderuk <s.shinderuk@postgrespro.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2023-08-23T13:23:20Z
Lists: pgsql-hackers

Attachments

> On 1 Aug 2023, at 16:44, Sergey Shinderuk <s.shinderuk@postgrespro.ru> wrote:

> A static analyzer reported a possible pfree(NULL) in be_tls_open_server().

This has the smell of a theoretical problem, I can't really imagine a
certificate where which would produce this.  Have you been able to trigger it?

Wouldn't a better fix be to error out on len == -1 as in the attached, maybe
with a "Shouldn't happen" comment?

--
Daniel Gustafsson

Commits

  1. Avoid potential pfree on NULL on OpenSSL errors