Horton

Re: Maximum password length

Nathan Bossart <bossartn@amazon.com>

View thread View on postgr.es
From: "Bossart, Nathan" <bossartn@amazon.com>
To: Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Alexander Kukushkin <cyberdemn@gmail.com>, Stephen Frost <sfrost@snowman.net>, "isaac.morland@gmail.com" <isaac.morland@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2020-09-03T20:06:55Z
Lists: pgsql-hackers 
On 9/3/20, 10:19 AM, "Tom Lane" <tgl@sss.pgh.pa.us> wrote:
> Hearing no objections to this general plan, I went ahead and did that
> cleanup.  This version seems committable to me.

                FILE       *pwf = fopen(pwfilename, "r");
-               int                     i;
+               char            pwdbuf[8192];

If I am reading correctly, this would be the only defined password
length limit once this patch is applied.  While it's probably unlikely
that this will cause problems for anybody anytime soon, is there any
reason not to give this the same treatment as the .pgpass code and
remove the line length limit altogether?

Otherwise, the patch looks good to me.

Nathan

Commits

  1. Remove arbitrary restrictions on password length.

  2. Remove support for password_encryption='off' / 'plain'.