Horton
Menu

Re: Use proc_exit() in WalRcvWaitForStartPosition

Chao Li <li.evan.chao@gmail.com>

View thread
From: Chao Li <li.evan.chao@gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Xuneng Zhou <xunengzhou@gmail.com>, Andreas Karlsson <andreas@proxel.se>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2026-04-12T23:33:02Z
Lists: pgsql-hackers

Attachments


> On Apr 10, 2026, at 22:17, Fujii Masao <masao.fujii@gmail.com> wrote:
> 
> On Fri, Apr 10, 2026 at 4:07 PM Chao Li <li.evan.chao@gmail.com> wrote:
>> PFA v2 - updated header comment of walreceive.c. I tried to avoid mentioning the exact exit value in the comment, so I just changed “exit(0)” to “terminate”.
> 
> Thanks for updating the patch!
> 
> "termination instructs XXX to terminate" sounds a bit redundant. How
> about saying
> "to ereport(FATAL)" instead of “to terminate”?
> 
> Regards,
> 
> 
> -- 
> Fujii Masao


Okay, yes, that was a bit redundant. I changed it to “to ereport(FATAL)” in v3.

After that change, the line went over 80 columns, so I also adjusted a few nearby lines to keep everything within the 80-column limit. There is no content change.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Use proc_exit() for walreceiver exit in WalRcvWaitForStartPosition()