Re: Fix \crosstabview to honor \pset display_true/display_false
Chao Li <li.evan.chao@gmail.com>
From: Chao Li <li.evan.chao@gmail.com>
To: Álvaro Herrera <alvherre@kurilemu.de>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>,
PostgreSQL-development <pgsql-hackers@postgresql.org>,
Bruce Momjian <bmomjian@gmail.com>
Date: 2026-06-21T00:37:53Z
Lists: pgsql-hackers
Attachments
- v3-0001-Make-crosstabview-honor-boolean-display-settings.patch (application/octet-stream) patch v3-0001
> On Jun 20, 2026, at 18:32, Álvaro Herrera <alvherre@kurilemu.de> wrote: > > On 2026-Jun-19, David G. Johnston wrote: > >> Chao's decision to include the row and column headers makes more sense to >> me. The promise of this feature is that the visual output of booleans as >> t/f should go away if the user chooses to make use of these >> local variables. While we may not be able get them all (e.g., >> composites and arrays) doing so here is trivial to accomplish. > > OK. TBH that part seemed a bit over the top to me, but that wasn't a > very strongly held opinion. I'll put that back and push soonish. > > -- > Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ > "La gente vulgar sólo piensa en pasar el tiempo; > el que tiene talento, en aprovecharlo" Thank you both very much for reviewing and for the valuable comments. I have made the helper private to crosstabview.c and left print.c unchanged in v3. I will see if I can improve print.h/c for v20. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/
Commits
-
Make crosstabview honor boolean/null display settings
- 4df5fe3833a8 19 (unreleased) landed