Horton

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Restart logical replication launcher when killed

  1. pgsql: Restart logical replication launcher when killed

    Peter Eisentraut <peter_e@gmx.net> — 2017-06-21T19:16:54Z

    Restart logical replication launcher when killed

Author: Yugo Nagata <nagata@sraoss.co.jp>

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f669c09989bda894d6ba01634ccb229f0687c08a

Modified Files
--------------
src/backend/tcop/postgres.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

  2. Re: [COMMITTERS] pgsql: Restart logical replication launcher when killed

    Michael Paquier <michael.paquier@gmail.com> — 2017-06-21T23:46:35Z

    On Thu, Jun 22, 2017 at 4:16 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
> Restart logical replication launcher when killed

-           /* The logical replication launcher can be stopped at any time. */
-           proc_exit(0);
+           /* The logical replication launcher can be stopped at any time.
+            * Use exit status 1 so the background worker is restarted. */
+           proc_exit(1);
I know I am noisy on the matter but... This comment format is not PG-like.
-- 
Michael

  3. Re: [COMMITTERS] pgsql: Restart logical replication launcher when killed

    Andres Freund <andres@anarazel.de> — 2017-06-21T23:52:16Z

    On 2017-06-22 08:46:35 +0900, Michael Paquier wrote:
> On Thu, Jun 22, 2017 at 4:16 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
> > Restart logical replication launcher when killed
> 
> -           /* The logical replication launcher can be stopped at any time. */
> -           proc_exit(0);
> +           /* The logical replication launcher can be stopped at any time.
> +            * Use exit status 1 so the background worker is restarted. */
> +           proc_exit(1);
> I know I am noisy on the matter but... This comment format is not PG-like.

That's since been repaired by the new pgindent run.  But what I'm a bit
confused about is why we're going for proc_exit() for replication
launchers when other types of processes simply FATAL out?  Seems like a
weird change.  It's not like it's not log-worthy if somebody kills the
launcher?

- Andres