pgsql: Preventive maintenance in advance of pgindent run.

Preventive maintenance in advance of pgindent run.

Reformat various places in which pgindent will make a mess, and
fix a few small violations of coding style that I happened to notice
while perusing the diffs from a pgindent dry run.

There is one actual bug fix here: the need-to-enlarge-the-buffer code
path in icu_convert_case was obviously broken.  Perhaps it's unreachable
in our usage?  Or maybe this is just sadly undertested.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c079673dcb7f210617c9fc1470e6bf166d8a2971

Modified Files
--------------
contrib/btree_gist/btree_utils_num.c           | 11 +++++---
src/backend/catalog/pg_publication.c           | 11 ++++----
src/backend/commands/publicationcmds.c         |  4 ++-
src/backend/commands/subscriptioncmds.c        |  1 +
src/backend/executor/nodeNamedtuplestorescan.c |  1 +
src/backend/replication/logical/snapbuild.c    |  2 +-
src/backend/replication/pgoutput/pgoutput.c    |  5 ++--
src/backend/tsearch/wparser.c                  | 13 ++++++----
src/backend/utils/adt/formatting.c             | 35 ++++++++++++++++++--------
src/backend/utils/adt/pg_locale.c              |  2 ++
src/bin/pg_basebackup/pg_basebackup.c          | 24 +++++++++---------
src/bin/pg_dump/dumputils.c                    |  3 +--
src/bin/pg_dump/pg_backup_archiver.h           |  4 +--
src/bin/pg_waldump/pg_waldump.c                | 18 ++++++-------
src/bin/psql/tab-complete.c                    |  7 +++---
src/common/scram-common.c                      |  3 ++-
src/include/catalog/pg_authid.h                | 16 ++++++------
src/include/catalog/pg_subscription_rel.h      | 14 +++++------
src/include/replication/logicalproto.h         |  6 +++--
src/interfaces/libpq/libpq-int.h               |  4 +--
20 files changed, 105 insertions(+), 79 deletions(-)