Horton
Menu

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. doc: Clarify OAuth validator authn_id logging

  1. pgsql: doc: Clarify OAuth validator authn_id logging

    Daniel Gustafsson <dgustafsson@postgresql.org> — 2026-06-05T22:22:05Z

    doc: Clarify OAuth validator authn_id logging

Document that OAuth validators can return an authenticated identity
in the authn_id member.  The server records the identity value before
checking if the connection is authorized, so it may appear in
connection-authentication logs (even if the connection later fails
authorization).

Also remove outdated wording saying that all result parameters are
ignored when a validator returns false since validators may provide
error_detail.

Patch by Chao Li with some additional wordsmithing by me.

Author: Chao Li <lic@highgo.com>
Reviewed-by: Jacob Champion <jacob.champion@enterprisedb.com>
Reported-by: Daniel Gustafsson <daniel@yesql.se>
Discussion: https://postgr.es/m/0281836A-F5FF-41A5-9EE1-656C1FAAC6B2@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4cb2e2fe0aa8251bef8c2e2351cd5a062c105c0a

Modified Files
--------------
doc/src/sgml/oauth-validators.sgml | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)

  2. Re: pgsql: doc: Clarify OAuth validator authn_id logging

    Erik Rijkers <er@xs4all.nl> — 2026-06-06T12:36:24Z

    Op 6/6/26 om 00:22 schreef Daniel Gustafsson:
> doc: Clarify OAuth validator authn_id logging
> 
> Author: Chao Li <lic@highgo.com>
> Reviewed-by: Jacob Champion <jacob.champion@enterprisedb.com>
> Reported-by: Daniel Gustafsson <daniel@yesql.se>
> Discussion: https://postgr.es/m/0281836A-F5FF-41A5-9EE1-656C1FAAC6B2@gmail.com
> 
> Branch
> ------
> master
> 
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/4cb2e2fe0aa8251bef8c2e2351cd5a062c105c0a
> 
> Modified Files
> --------------
> doc/src/sgml/oauth-validators.sgml | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)

Hi,

In doc/src/sgml/oauth-validators.sgml, and if I understand this text 
correctly (always a big if), then:

"If the validator returns true and set result->authn_id then"

should be:
"If the validator returns true and sets result->authn_id then"
   (i.e., set -> sets)

(added Michael in CC as he seems to collect these minimal patches, to be 
committed later as a group)

Thanks,

Erik

  3. Re: pgsql: doc: Clarify OAuth validator authn_id logging

    Michael Paquier <michael@paquier.xyz> — 2026-06-07T23:56:04Z

    On Sat, Jun 06, 2026 at 02:36:24PM +0200, Erik Rijkers wrote:
> In doc/src/sgml/oauth-validators.sgml, and if I understand this text
> correctly (always a big if), then:
> 
> "If the validator returns true and set result->authn_id then"
> 
> should be:
> "If the validator returns true and sets result->authn_id then"
>   (i.e., set -> sets)
> 
> (added Michael in CC as he seems to collect these minimal patches, to be
> committed later as a group)

In auth-oauth.c, there is a validate() path setting the authn_id, so
your suggestion sounds right.  I've grabbed that for later.  My branch
can always be overwritten by somebody else's commit preference, of
course, so if you feel that this should be fixed separately, feel free
to go ahead.
--
Michael