Thread

1. Re: pg_dump -Ft failed on Windows XP

   Zeugswetter Andreas ADI SD <zeugswettera@spardat.at> — 2006-04-21T09:11:46Z

   > >> Apparently it won't work at all if TMP isn't set?
   > 
   > > I'm not *too* concerned about that, since TMP is normally set by the
   OS
   > > itself. There's one set in the "system environment" (to
   c:\windows\temp
   > > or whatrever) and then it's overridden by one set by the OS when it
   > > loads a user profile.
   > 
   > OK, then maybe not having it would be equivalent to /tmp-not-writable
   > on Unix, ie, admin error.
   > 
   > > Also to the point, what would you fall back to?
   > 
   > Current directory maybe?
   
   It tries \ (tested on Win 2000), if the dir argument is NULL and TMP is
   not set.
   But TMP is usually set. 
   
   Attached is a working version not yet adapted to port/.
   - memoryleak fixed
   - use _tmpname and _fdopen not the compatibility tmpname and fdopen
   (imho only cosmetic)
   - EACCES fixed (Win2000 needs _S_IREAD | _S_IWRITE or fails with EACCES,
   even as Admin)
   - I suggest adding a prefix pg_temp_ (for leftover temp files after
   crash, 
   	the name I get is then usually pg_temp_2)
   
   Andreas
   

2. Re: pg_dump -Ft failed on Windows XP

   Bruce Momjian <pgman@candle.pha.pa.us> — 2006-06-16T21:36:58Z

   Someday we can  move this to /port, but for now, let's get it into CVS.
   
   Your patch has been added to the PostgreSQL unapplied patches list at:
   
   	http://momjian.postgresql.org/cgi-bin/pgpatches
   
   It will be applied as soon as one of the PostgreSQL committers reviews
   and approves it.
   
   ---------------------------------------------------------------------------
   
   
   Zeugswetter Andreas DCP SD wrote:
   > 
   > > >> Apparently it won't work at all if TMP isn't set?
   > > 
   > > > I'm not *too* concerned about that, since TMP is normally set by the
   > OS
   > > > itself. There's one set in the "system environment" (to
   > c:\windows\temp
   > > > or whatrever) and then it's overridden by one set by the OS when it
   > > > loads a user profile.
   > > 
   > > OK, then maybe not having it would be equivalent to /tmp-not-writable
   > > on Unix, ie, admin error.
   > > 
   > > > Also to the point, what would you fall back to?
   > > 
   > > Current directory maybe?
   > 
   > It tries \ (tested on Win 2000), if the dir argument is NULL and TMP is
   > not set.
   > But TMP is usually set. 
   > 
   > Attached is a working version not yet adapted to port/.
   > - memoryleak fixed
   > - use _tmpname and _fdopen not the compatibility tmpname and fdopen
   > (imho only cosmetic)
   > - EACCES fixed (Win2000 needs _S_IREAD | _S_IWRITE or fails with EACCES,
   > even as Admin)
   > - I suggest adding a prefix pg_temp_ (for leftover temp files after
   > crash, 
   > 	the name I get is then usually pg_temp_2)
   > 
   > Andreas
   
   Content-Description: pg_dump_tempfile.patch.txt
   
   [ Attachment, skipping... ]
   
   > 
   > ---------------------------(end of broadcast)---------------------------
   > TIP 2: Don't 'kill -9' the postmaster
   
   -- 
     Bruce Momjian   http://candle.pha.pa.us
     EnterpriseDB    http://www.enterprisedb.com
   
     + If your life is a hard drive, Christ can be your backup. +
   
   

3. Re: [HACKERS] pg_dump -Ft failed on Windows XP

   Bruce Momjian <bruce@momjian.us> — 2006-06-27T01:18:44Z

   Modified patch attached and applied to HEAD and 8.1.X.
   
   I restructured the loop exit, and used the symbols without the leading
   underscores.  I didn't see any Win32 underscore symbol usage in our
   existing code.
   
   Thanks.
   
   -------------------------------------------------------------------------
   
   Zeugswetter Andreas DCP SD wrote:
   > 
   > > >> Apparently it won't work at all if TMP isn't set?
   > > 
   > > > I'm not *too* concerned about that, since TMP is normally set by the
   > OS
   > > > itself. There's one set in the "system environment" (to
   > c:\windows\temp
   > > > or whatrever) and then it's overridden by one set by the OS when it
   > > > loads a user profile.
   > > 
   > > OK, then maybe not having it would be equivalent to /tmp-not-writable
   > > on Unix, ie, admin error.
   > > 
   > > > Also to the point, what would you fall back to?
   > > 
   > > Current directory maybe?
   > 
   > It tries \ (tested on Win 2000), if the dir argument is NULL and TMP is
   > not set.
   > But TMP is usually set. 
   > 
   > Attached is a working version not yet adapted to port/.
   > - memoryleak fixed
   > - use _tmpname and _fdopen not the compatibility tmpname and fdopen
   > (imho only cosmetic)
   > - EACCES fixed (Win2000 needs _S_IREAD | _S_IWRITE or fails with EACCES,
   > even as Admin)
   > - I suggest adding a prefix pg_temp_ (for leftover temp files after
   > crash, 
   > 	the name I get is then usually pg_temp_2)
   > 
   > Andreas
   
   Content-Description: pg_dump_tempfile.patch.txt
   
   [ Attachment, skipping... ]
   
   > 
   > ---------------------------(end of broadcast)---------------------------
   > TIP 2: Don't 'kill -9' the postmaster
   
   -- 
     Bruce Momjian   bruce@momjian.us
     EnterpriseDB    http://www.enterprisedb.com
   
     + If your life is a hard drive, Christ can be your backup. +