Horton

Thread

Commits

  1. pg_upgrade: include additional detail in cluster check

  1. Giving more detail in pg_upgrade errormessage

    Daniel Gustafsson <daniel@yesql.se> — 2023-07-18T14:59:32Z

    Looking at the upgrade question in [0] made me realize that we discard
potentially useful information for troubleshooting.  When we check if the
cluster is properly shut down we might as well include the status from
pg_controldata in the errormessage as per the trivial (but yet untested)
proposed diff.

Is there a reason not to be verbose here as users might copy/paste this output
when asking for help?

--
Daniel Gustafsson

[0] CACoPQdbQTysF=EKckyFNGTdpOdXXMEsf_2ACno+bcNqQCB5raA@mail.gmail.com

  2. Re: Giving more detail in pg_upgrade errormessage

    Zhang Mingli <zmlpostgres@gmail.com> — 2023-07-18T15:17:24Z

    Hi,

> Is there a reason not to be verbose here as users might copy/paste this output
> when asking for help?

Seems better than nothing.

> [0] CACoPQdbQTysF=EKckyFNGTdpOdXXMEsf_2ACno+bcNqQCB5raA@mail.gmail.com


Full link for convenience.

[0]https://www.postgresql.org/message-id/CACoPQdbQTysF=EKckyFNGTdpOdXXMEsf_2ACno+bcNqQCB5raA@mail.gmail.com

Zhang Mingli
https://www.hashdata.xyz

  3. Re: Giving more detail in pg_upgrade errormessage

    Tom Lane <tgl@sss.pgh.pa.us> — 2023-07-18T16:04:20Z

    Daniel Gustafsson <daniel@yesql.se> writes:
> Looking at the upgrade question in [0] made me realize that we discard
> potentially useful information for troubleshooting.  When we check if the
> cluster is properly shut down we might as well include the status from
> pg_controldata in the errormessage as per the trivial (but yet untested)
> proposed diff.

> Is there a reason not to be verbose here as users might copy/paste this output
> when asking for help?

Agreed, but I think you need to chomp the string's trailing newline,
or it'll look ugly.  You might as well do that further up and remove
the newlines from the comparison strings, too.

			regards, tom lane

  4. Re: Giving more detail in pg_upgrade errormessage

    Daniel Gustafsson <daniel@yesql.se> — 2023-07-19T20:26:02Z

    > On 18 Jul 2023, at 18:04, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> Daniel Gustafsson <daniel@yesql.se> writes:
>> Looking at the upgrade question in [0] made me realize that we discard
>> potentially useful information for troubleshooting.  When we check if the
>> cluster is properly shut down we might as well include the status from
>> pg_controldata in the errormessage as per the trivial (but yet untested)
>> proposed diff.
> 
>> Is there a reason not to be verbose here as users might copy/paste this output
>> when asking for help?
> 
> Agreed, but I think you need to chomp the string's trailing newline,
> or it'll look ugly.  You might as well do that further up and remove
> the newlines from the comparison strings, too.

Yeah, the previous diff was mostly a sketch.  The attached strips newline and
makes the comparisons a bit neater in the process due to that.  Will apply this
trivial but seemingly useful change unless objected to.

--
Daniel Gustafsson