Horton
Menu

Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions

Daniel Gustafsson <daniel@yesql.se>

View thread
From: Daniel Gustafsson <daniel@yesql.se>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Sugamoto Shinya <shinya34892@gmail.com>, Nathan Bossart <nathandbossart@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Chao Li <li.evan.chao@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Peter Eisentraut <peter@eisentraut.org>
Date: 2025-11-19T13:04:44Z
Lists: pgsql-hackers 
> On 19 Nov 2025, at 14:01, Fujii Masao <masao.fujii@gmail.com> wrote:

> You changed the HINT message to use format arguments,
> but I still think it's better to embed the values directly (e.g.,
> Valid encodings are "base64", "base64url", "escape", and "hex".)
> for consistency with similar HINT messages. If this message is
> used in many places a parameterized style would help translators,
> but that benefit doesn't apply here.
> 
> Attached is an updated version of the patch. I switched
> the HINT message to the embedded form and updated the commit message.
> Barring any objections, I'm thinking to commit this.

My intepreration was that this version was already objected to by Peter
upthread in c5c937dc-de8e-4284-be25-5d5eaf089d00@eisentraut.org.  The point
there being that punctuation in lists is subject to translation.

--
Daniel Gustafsson

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add HINT listing valid encodings to encode() and decode() errors.

  2. Revise GUC names quoting in messages again

  3. doc: Mention how to use quotes with GUC names in error messages

  4. Adjust assorted hint messages that list all valid options.