Horton

Re: Fix publisher-side sequence permission reporting

Tristan Partin <tristan@partin.io>

View thread View on postgr.es
From: "Tristan Partin" <tristan@partin.io>
To: "Fujii Masao" <masao.fujii@gmail.com>
Cc: "PostgreSQL Hackers" <pgsql-hackers@lists.postgresql.org>
Date: 2026-06-19T16:38:27Z
Lists: pgsql-hackers 
On Fri Jun 19, 2026 at 9:16 AM CDT, Fujii Masao wrote:
> On Fri, Jun 19, 2026 at 8:11 AM Tristan Partin <tristan@partin.io> wrote:
>> The patch looks good to me! I had one suggestion:
>>
>> >  ##########
>> >  # Ensure that insufficient privileges on the publisher for a sequence do not
>> > -# disrupt the subscriber. The subscriber should log a warning and continue
>> > -# retrying.
>> > +# get misreported as a missing sequence. The subscriber should log a warning
>> > +# and continue retrying.
>> >  ##########
>>
>> I think a better comment might be:
>>
>>         Ensure that insufficient privileges on the publisher for a sequence
>>         are reported correctly...
>>
>> My reasoning for suggesting that is because your comment would to
>> indicate that any warning is accurate as long as it isn't related to
>> a missing sequence.
>
> Thanks for the review! I've updated the patch as suggested.
>
> Updated patches attached.

Looks great! Thanks for fixing this.

-- 
Tristan Partin
PostgreSQL Contributors Team
AWS (https://aws.amazon.com)

Commits

  1. Fix unlogged sequence corruption after standby promotion

  2. doc: Clarify pg_get_sequence_data() privileges and NULL results

  3. Fix misreporting of publisher sequence permissions during sync

  4. Introduce pg_sequence_read_tuple().