Re: Safer hash table initialization macro
Jelte Fennema <postgres@jeltef.nl>
From: "Jelte Fennema-Nio" <postgres@jeltef.nl>
To: "Bertrand Drouvot" <bertranddrouvot.pg@gmail.com>
Cc: "Thomas Munro" <thomas.munro@gmail.com>,
<pgsql-hackers@lists.postgresql.org>
Date: 2026-01-26T10:05:49Z
Lists: pgsql-hackers
Attachments
- v8-0001-Add-hash_make-macros.patch (text/x-patch) patch v8-0001
- v8-0002-Add-foreach_hash-macro.patch (text/x-patch) patch v8-0002
- v8-0003-Use-hash_make-macros-throughout-the-codebase.patch (text/x-patch) patch v8-0003
- v8-0004-Use-foreach_hash-macro-throughout-the-codebase.patch (text/x-patch) patch v8-0004
- v8-0005-Inline-functions-that-have-now-become-trivial.patch (text/x-patch) patch v8-0005
On Mon Jan 26, 2026 at 9:41 AM CET, Bertrand Drouvot wrote: > Hi, > > On Mon, Jan 26, 2026 at 12:38:15AM +0100, Jelte Fennema-Nio wrote: >> On Wed Jan 14, 2026 at 9:46 AM CET, Jelte Fennema-Nio wrote: >> > Changed wording and changed to NOTE. >> >> Attached is v7 which is rebased and changed the hash_create calls >> introduced by 282b1cde9de. > > Thanks! > > The changes make sense to me. > > Just a pgindent nit, in 0003: Fixed > Also, I can see (I think it's coming from 0004): Are you sure you applied the latest one, I had seen that in CI and fixed it in v7. Should definitely be fixed now at least.