Horton

Re: BUG #17391: While using --with-ssl=openssl and PG_TEST_EXTRA='ssl' options, SSL tests fail on OpenBSD 7.0

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Daniel Gustafsson <daniel@yesql.se>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@gmail.com>, byavuz81@gmail.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>, Heikki Linnakangas <heikki.linnakangas@iki.fi>, Michael Paquier <michael@paquier.xyz>
Date: 2022-02-03T15:55:36Z
Lists: pgsql-bugs 
Hi, 

On February 3, 2022 7:48:40 AM PST, Daniel Gustafsson <daniel@yesql.se> wrote:
>Pouring over SSL test logs I was again red-herringed by the warning we get for
>using hex() on a large input value, before I remembered that it's benign and
>emerged from the rabbithole:
>
>  Hexadecimal number > 0xffffffff non-portable at t/001_ssltests.pl line 508.
>
>We could suppress it by turning off warnings for that line, since we know it
>will work due to the 64-bit int test a few lines before:
>
>@@ -505,6 +505,7 @@ if ($? == 0)
>        {
>                $serialno =~ s/^serial=//;
>                $serialno =~ s/\s+//g;
>+               local $SIG{'__WARN__'} = sub { };
>                $serialno = hex($serialno);
>        }
>        else
>
>Turning of warnings might be a bridge too far for some though? Thoughts?

Can't we just chop serialno into two 32bit numbers and call hex separately? Seems about as hard as adding a comment explaining what the warn bit is about...

Andres

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Commits

  1. Move libpq's write_failed mechanism down to pqsecure_raw_write().

  2. Fix thinko in PQisBusy().

  3. Set SNI ClientHello extension to localhost in tests

  4. Improve worst-case performance of text_position_get_match_pos()