Re: Add jsonlog log_destination for JSON server logs

Nathan Bossart <bossartn@amazon.com>

From: "Bossart, Nathan" <bossartn@amazon.com>

To: Michael Paquier <michael@paquier.xyz>, Sehrope Sarkuni <sehrope@jackdb.com>

Cc: Pg Hackers <pgsql-hackers@postgresql.org>, "david@fetter.org" <david@fetter.org>

Date: 2021-10-07T06:00:08Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Introduce log_destination=jsonlog
- dc686681e079 15.0 landed
Refactor set of routines specific to elog.c
- ac7c80758a7a 15.0 landed
Fix compilation warning in syslogger.c
- 05c4248ad1bf 15.0 landed
Refactor per-destination file rotation in logging collector
- 5c6e33f07153 15.0 landed
Refactor output file handling when forking syslogger under EXEC_BACKEND
- 5b0b699f748e 15.0 landed
Add regression tests for csvlog with the logging collector
- 72b76f76161c 15.0 landed
Refactor the syslogger pipe protocol to use a bitmask for its options
- 2d77d835403a 15.0 landed

Attachments

fix_warning.patch (application/octet-stream) patch

On 10/5/21, 12:22 AM, "Michael Paquier" <michael@paquier.xyz> wrote:
> - 0001 does some refactoring of the file rotation in syslogger.c,
> that's the same patch as previously posted.

My compiler is unhappy with 5c6e33f:

        syslogger.c: In function ‘logfile_rotate_dest’:
        syslogger.c:1302:11: warning: ‘logFileExt’ may be used uninitialized in this function [-Wmaybe-uninitialized]
        filename = logfile_getname(fntime, logFileExt);
        ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The attached patch seems to fix it.

Nathan