Horton

Thread

Commits

  1. Fix collection of typos in the code and the documentation

  1. [PATCH] Fix various spelling errors

    Kekalainen, Otto <ottoke@amazon.com> — 2022-03-14T23:03:50Z

     Hello!

I propose the attached patch to be applied on the 'master' branch of PostgreSQL
to fix various spelling errors.

Most fixes are in comments and have no effect on functionality. Some fixes are
also in variable names but they should be safe to change, as the change is
consistent in all occurrences of the variable.

Otto Kekalainen
Amazon Web Services: https://aws.amazon.com

  2. Re: [PATCH] Fix various spelling errors

    Justin Pryzby <pryzby@telsasoft.com> — 2022-03-14T23:49:07Z

    On Mon, Mar 14, 2022 at 11:03:50PM +0000, Kekalainen, Otto wrote:
>  Hello!
> 
> I propose the attached patch to be applied on the 'master' branch of PostgreSQL
> to fix various spelling errors.
> 
> Most fixes are in comments and have no effect on functionality. Some fixes are
> also in variable names but they should be safe to change, as the change is
> consistent in all occurrences of the variable.

LGTM - I found a few of these myself.
Attached now, in case it's useful to handle them together.

  3. Re: [PATCH] Fix various spelling errors

    Michael Paquier <michael@paquier.xyz> — 2022-03-15T02:46:24Z

    On Mon, Mar 14, 2022 at 06:49:07PM -0500, Justin Pryzby wrote:
> On Mon, Mar 14, 2022 at 11:03:50PM +0000, Kekalainen, Otto wrote:
>> I propose the attached patch to be applied on the 'master' branch of PostgreSQL
>> to fix various spelling errors.
>> 
>> Most fixes are in comments and have no effect on functionality. Some fixes are
>> also in variable names but they should be safe to change, as the change is
>> consistent in all occurrences of the variable.
> 
> LGTM - I found a few of these myself.
> Attached now, in case it's useful to handle them together.

It is useful to group that together.  I have gathered everything that
looked like a typo or a grammar mistake, and applied the fixes.
Thanks!
--
Michael

  4. Re: [PATCH] Fix various spelling errors

    Kekalainen, Otto <ottoke@amazon.com> — 2022-03-15T16:40:42Z

    On 2022-03-14, 19:47, "Michael Paquier" <michael@paquier.xyz> wrote:
>    It is useful to group that together.  I have gathered everything that
>   looked like a typo or a grammar mistake, and applied the fixes.

That was quick, thanks!

Please next time use `git am` to import the patch so that author and other
commit metadata is kept, or if you apply patches manually then commit with `git
--author` so that original author will be correct in the commit and your name
will be only in the committer field.

This was just a spelling fix so I don't care, but for other people doing more
significant contributions, getting the git authorship and having a PostgreSQL
contribution show up on their Gihub (or Gitlab profile, or in other tools that
read git commits) can be important and maybe the only reward/credit for those
doing open source on their free time.

Again, personally I don't care and I don't need Github credits for this, just
stating as general advice for a better contribution process in the future.

- Otto

  5. Re: [PATCH] Fix various spelling errors

    Tom Lane <tgl@sss.pgh.pa.us> — 2022-03-15T16:46:34Z

    "Kekalainen, Otto" <ottoke@amazon.com> writes:
> Please next time use `git am` to import the patch so that author and other
> commit metadata is kept, or if you apply patches manually then commit with `git
> --author` so that original author will be correct in the commit and your name
> will be only in the committer field.

This is not our practice.  We credit authors in the body of the commit
message, but we don't worry about the git metadata.  git is a tool we
happen to be using at the moment, but it doesn't run the project,
and in any case it's far short of being adequate for such a purpose.
What would you do with multiple-author patches, for a start?

			regards, tom lane