Re: [PATCH] Add native windows on arm64 support

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>, Thomas Munro <thomas.munro@gmail.com>, Andres Freund <andres@anarazel.de>, Julien Rouhaud <rjuju123@gmail.com>, Niyas Sait <niyas.sait@linaro.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-04-07T14:55:27Z
Lists: pgsql-hackers
> On 7 Apr 2022, at 15:40, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> Michael Paquier <michael@paquier.xyz> writes:
>> On Fri, Mar 25, 2022 at 11:38:44AM +1300, Thomas Munro wrote:
>>> Yeah.  I think we should commit this patch, but decree that
>>> Windows/aarch64 support is experimental only for now.  That allows a
>>> build farm animal to be set up.  Then we add a bit of extra logging
>>> and see how it does running our test suite over time and learn more.
> 
>> I don't have such a setup so my testing capabilities are limited.
>> Does anybody have one?  I think that we could be flexible for this
>> patch, even after feature freeze as it introduces something entirely
>> new without impacting the existing code.  The patch has been moved to
>> the next CF for now.
> 
> I dunno, the lack of any in-house capability for this makes me very
> nervous.  If it causes problems down the road, how will we debug it?

If those with an interest in such platform support cannot spare the cycles to
at least run a buildfarm member, then it seems a stretch for us to maintain
such support with any confidence.

> So it seems like the sort of patch to put in at the beginning of a
> development cycle, not post-feature-freeze.

+1

--
Daniel Gustafsson		https://vmware.com/




Commits

  1. MSVC: Support building for AArch64.

  2. Remove "#ifdef WIN32" guards from src/port/win32*.c

  3. Adjust XML test case to avoid unstable behavior.

  4. Enable RandomizedBaseAddress (ASLR) on Windows with MSVC builds