Re: Remove unnecessary static specifier

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>
To: Japin Li <japinli@hotmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-02-06T15:39:51Z
Lists: pgsql-hackers
> On 6 Feb 2025, at 02:51, Japin Li <japinli@hotmail.com> wrote:
> 
> On Wed, 05 Feb 2025 at 18:17, Daniel Gustafsson <daniel@yesql.se> wrote:
>>> On 5 Feb 2025, at 17:05, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> 
>>> While we're at it, could we make the adjacent "magic" string be
>>> "static const char *magic"?  (Probably needs a couple more
>>> "const" modifiers at use sites, too.)
>> 
>> Good point, from the link referenced it's clear that FreeBSD has made that
>> change as well.  I'll fix that at the same time.
> 
> Oh, I didn't notice this. +1.

Committed, thanks!

--
Daniel Gustafsson




Commits

  1. pgcrypto: Remove static storage class from variables