Re: "openssl" should not be optional

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>

To: Christoph Berg <myon@debian.org>

Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-09-24T13:57:46Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Avoid warnings in tests when openssl binary isn't available
- f01c4eb4e901 17.7 landed
- bf5b26525b28 16.11 landed
- 7d129ba54e74 19 (unreleased) landed
- 150a1b328778 18.1 landed

Attachments

v2-0001-Avoid-warnings-in-ssl-tests-when-openssl-isn-t-av.patch (application/octet-stream) patch v2-0001

> On 24 Sep 2025, at 13:51, Christoph Berg <myon@debian.org> wrote:

>> Do you feel like expanding your patch or should I?
> 
> TBH I know very little about how TAP interfaces with the build system,
> so that's better with you.

Looking at this I was reminded that we already handle this by using a fallback
and the test worked all along.  The message for this was quite poorly worded
though, and used a warning instead of a note.  The attached will try to detect
openssl being missing before trying to run it, and will skip the warning
message if the fallback is used (which really isn't a warning in the first
place).

The ERROR in 003_sslinfo is intentional, we are testing that processing fails
by passing an invalid value.

--
Daniel Gustafsson