Horton

Re: Report error position in partition bound check

Alexandra Wang <walexandra@vmware.com>

View thread View on postgr.es
From: Alexandra Wang <walexandra@vmware.com>
To: Daniel Gustafsson <daniel@yesql.se>, "Alexandra Wang (Pivotal)" <lewang@pivotal.io>
Cc: Ashutosh Bapat <ashutosh.bapat@2ndquadrant.com>, Amit Langote <amitlangote09@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>, "Ashwin Agrawal (Pivotal)" <aagrawal@pivotal.io>
Date: 2020-07-13T17:53:46Z
Lists: pgsql-hackers

Attachments

> On 2 July 2020, at 06:39, Daniel Gustafsson <daniel@yesql.se> wrote:
> > On 10 Apr 2020, at 23:50, Alexandra Wang <lewang@pivotal.io> wrote:
>
> > On Fri, Apr 10, 2020 at 8:37 AM Ashutosh Bapat <ashutosh.bapat@2ndquadrant.com <mailto:ashutosh.bapat@2ndquadrant.com>> wrote:
> > > for a multi-key value the ^
> > > points to the first column and the reader may think that that's the
> > > problematci column. Should it instead point to ( ?
> >
> > I attached a v2 of Amit's 0002 patch to also report the exact column
> > for the partition overlap errors.
>
> This patch fails to apply to HEAD due to conflicts in the create_table expected
> output.  Can you please submit a rebased version?  I'm marking the CF entry
> Waiting on Author in the meantime.

Thank you Daniel. Here's the rebased patch. I also squashed the two
patches into one so it's easier to review.

--
Alex

Commits

  1. Improve error cursor positions for problems with partition bounds.