Horton
Menu

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix documentation for pg_stat_recovery_prefetch.

  2. doc: Update the layout of "Viewing Statistics" section.

  3. Doc: reformat catalog/view description tables.

  1. Documentation issue with pg_stat_recovery_prefetch

    sirisha chamarthi <sirichamarthi22@gmail.com> — 2022-04-11T20:11:40Z

    Hi,

I was going through pg_stat_recovery_prefetch documentation and saw an
issue with formatting. Attached a small patch to fix the issue. This is the
first time I am sending an email to hackers. Please educate me if I
miss something.

https://www.postgresql.org/docs/devel/monitoring-stats.html#PG-STAT-RECOVERY-PREFETCH-VIEW

Thanks,
Sirisha

  2. Re: Documentation issue with pg_stat_recovery_prefetch

    Thomas Munro <thomas.munro@gmail.com> — 2022-04-12T09:22:59Z

    On Tue, Apr 12, 2022 at 8:11 AM sirisha chamarthi
<sirichamarthi22@gmail.com> wrote:
> I was going through pg_stat_recovery_prefetch documentation and saw an issue with formatting. Attached a small patch to fix the issue. This is the first time I am sending an email to hackers. Please educate me if I miss something.

Thanks Sirisha!

Ouch, that's embarrassing.  My best guess is that I might have screwed
that up a long time ago while rebasing an early development version
over commit 92f94686, which changed the link style and moved
paragraphs around, and then never noticed that it was wrong.
Researching that made me notice another problem: the table was using
the 3 column layout from a couple of years ago, because I had also
missed the style change in commit a0427506.  Oops.  Fixed.

  3. RE: Documentation issue with pg_stat_recovery_prefetch

    Shinoda, Noriyoshi <noriyoshi.shinoda@hpe.com> — 2022-04-20T12:38:54Z

    Hi, 

Thank you for developing the new feature.
The pg_stat_recovery_prefetch view documentation doesn't seem to have a description of the stats_reset column. The attached small patch adds a description of the stats_reset column.

Regards,
Noriyoshi Shinoda

-----Original Message-----
From: Thomas Munro <thomas.munro@gmail.com> 
Sent: Tuesday, April 12, 2022 6:23 PM
To: sirisha chamarthi <sirichamarthi22@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Documentation issue with pg_stat_recovery_prefetch

On Tue, Apr 12, 2022 at 8:11 AM sirisha chamarthi <sirichamarthi22@gmail.com> wrote:
> I was going through pg_stat_recovery_prefetch documentation and saw an issue with formatting. Attached a small patch to fix the issue. This is the first time I am sending an email to hackers. Please educate me if I miss something.

Thanks Sirisha!

Ouch, that's embarrassing.  My best guess is that I might have screwed that up a long time ago while rebasing an early development version over commit 92f94686, which changed the link style and moved paragraphs around, and then never noticed that it was wrong.
Researching that made me notice another problem: the table was using the 3 column layout from a couple of years ago, because I had also missed the style change in commit a0427506.  Oops.  Fixed.