RE: running logical replication as the subscription owner

Shinoda, Noriyoshi <noriyoshi.shinoda@hpe.com>

From: "Shinoda, Noriyoshi (PN Japan FSIP)" <noriyoshi.shinoda@hpe.com>

To: Robert Haas <robertmhaas@gmail.com>, Noah Misch <noah@leadboat.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Cc: Jeff Davis <pgsql@j-davis.com>, Jelte Fennema <postgres@jeltef.nl>, Andres Freund <andres@anarazel.de>

Date: 2023-04-11T02:09:24Z

Lists: pgsql-hackers

Attachments

pg_subscription_doc_v1.diff (application/octet-stream) patch v1

Hi hackers,
Thank you for developing a great feature. 
The following commit added a column to the pg_subscription catalog.
 https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=482675987bcdffb390ae735cfd5f34b485ae97c6
 https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=c3afe8cf5a1e465bd71e48e4bc717f5bfdc7a7d6

I found that the documentation of the pg_subscription catalog was missing an explanation of the columns subrunasowner and subpasswordrequired, so I attached a patch. Please fix the patch if you have a better explanation.

Regards,
Noriyoshi Shinoda

-----Original Message-----
From: Robert Haas <robertmhaas@gmail.com> 
Sent: Wednesday, April 5, 2023 1:10 AM
To: Noah Misch <noah@leadboat.com>
Cc: Jeff Davis <pgsql@j-davis.com>; Jelte Fennema <postgres@jeltef.nl>; pgsql-hackers@postgresql.org; Andres Freund <andres@anarazel.de>
Subject: Re: running logical replication as the subscription owner

On Mon, Apr 3, 2023 at 10:09 PM Noah Misch <noah@leadboat.com> wrote:
> I gather we agree on what to do for v16, which is good.

I have committed the patches.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Honor run_as_owner option in tablesync worker.
- a83edeaf684a 16.0 landed
Document new pg_subscription columns.
- bc25d6c54a00 16.0 landed
Add a run_as_owner option to subscriptions.
- 482675987bcd 16.0 landed
Perform logical replication actions as the table owner.
- 1e10d49b65d6 16.0 landed
Add new predefined role pg_create_subscription.
- c3afe8cf5a1e 16.0 cited
Respect permissions within logical replication.
- a2ab9c06ea15 15.0 cited
Empty search_path in logical replication apply worker and walsender.
- 11da97024abb 14.0 cited
Empty search_path in Autovacuum and non-psql/pgbench clients.
- 582edc369cdb 11.0 cited