Re: [PATCH] contrib/xml2: xslt_process() should report XSLT-related error details

Robin Haberkorn <haberkorn@b1-systems.de>

From: "Robin Haberkorn" <haberkorn@b1-systems.de>
To: <pgsql-hackers@postgresql.org>
Cc: "Tom Lane" <tgl@sss.pgh.pa.us>
Date: 2025-04-28T11:12:22Z
Lists: pgsql-hackers
On Tue Apr 22, 2025 at 17:47:20 GMT +03, Robin Haberkorn wrote:
> Perhaps you can tell me what else is preventing adoption into core. I believe
> that xslt_process() should also accept the `xml` type as an alternative to
> strings. Strings should be kept for backwards compatibility, though. Also,
> the stylesheet parameter passing is very crude and limited. I suggest, that
> the current method of passing them as strings (see parse_params()) is
> deprecated and we don't try to tackle its limitations, but will instead
> accept hstores. If you agree, I will work on these two tasks next.

On the other hand, since hstore is a module, it seems we cannot really
have any other module or core depend on it, correct?
Perhaps the xmltype-variant of xslt_process() could accept string arrays
instead.
 
-- 
Robin Haberkorn
Senior Software Engineer

B1 Systems GmbH
Osterfeldstraße 7 / 85088 Vohburg / https://www.b1-systems.de
GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt, HRB 3537



Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Fix up misuse of "volatile" in contrib/xml2.

  2. xml2: Improve error handling of libxml2 calls

  3. Rewrite libxml error handling to be more robust.