Re: Decouple C++ support in Meson's PGXS from LLVM enablement

Tristan Partin <tristan@partin.io>

From: "Tristan Partin" <tristan@partin.io>
To: "Jelte Fennema-Nio" <me@jeltef.nl>
Cc: "pgsql-hackers" <pgsql-hackers@postgresql.org>, "Andres Freund" <andres@anarazel.de>
Date: 2025-04-17T13:18:40Z
Lists: pgsql-hackers
On Thu Apr 17, 2025 at 2:15 AM CDT, Jelte Fennema-Nio wrote:
> On Thu, 17 Apr 2025 at 03:57, Tristan Partin <tristan@partin.io> wrote:
>> I spent some time exploring the Meson build a bit, and I realized that
>> C++ support in PGXS is tied to LLVM enablement. Checking the autotools
>> build in the configure.ac script indicates that that is not the case for
>> it.
>
> Thank you for looking into this. I didn't try the patch, but just
> reading it it all looks sensible (although my meson knowledge is quite
> limited). I assume you tried to build pg_duckdb with a Meson based PG
> build containing this patch and pg_duckdb built correctly?

I took some time to backpatch to 17 on my machine so that I could build 
pg_duckdb, and indeed with the backpatch applied, pg_duckdb compiles 
successfully.

I do however hit linker errors later, but that is unrelated to the 
current patch discussion. I'll discuss them with you in a different 
forum.

-- 
Tristan Partin
https://tristan.partin.io