Horton

Re: review: CHECK FUNCTION statement

Albe Laurenz <laurenz.albe@wien.gv.at>

View thread
From: "Albe Laurenz" <laurenz.albe@wien.gv.at>
To: "Pavel Stehule *EXTERN*" <pavel.stehule@gmail.com>
Cc: "PostgreSQL Hackers" <pgsql-hackers@postgresql.org>
Date: 2011-12-12T15:49:18Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add const qualifiers to node inspection functions

Pavel Stehule wrote:
> there is merged patch

Works fine, except that there are still missing const qualifiers
in copyfuncs.c and equalfuncs.c that lead to compiler warnings.

One thing I forgot to mention:
I thought there was a consensus to add a WITH() or OPTIONS() clause
to pass options to the checker function:
http://archives.postgresql.org/message-id/12568.1322669638@sss.pgh.pa.us

I think this should be there so that the API does not have to be
changed in the future.

Yours,
Laurenz Albe