Horton

Re: Online checksums verification in the backend

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>, Michael Paquier <michael@paquier.xyz>, Robert Haas <robertmhaas@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Masahiko Sawada <sawada.mshk@gmail.com>
Date: 2020-07-05T21:00:30Z
Lists: pgsql-hackers 
> On 5 Apr 2020, at 13:17, Julien Rouhaud <rjuju123@gmail.com> wrote:
> On Sun, Apr 05, 2020 at 08:01:36PM +0900, Masahiko Sawada wrote:

>> Thank you for updating the patch! The patch looks good to me.
>> 
>> I've marked this patch as Ready for Committer. I hope this patch will
>> get committed to PG13.

> Thanks a lot!

This patch has been through quite thorough review, and skimming the thread all
concerns raised have been addressed.  It still applies and tests gree in the CF
Patchtester.  The feature in itself certainly gets my +1 for inclusion, it
seems a good addition.

Is any committer who has taken part in the thread (or anyone else for that
matter) interested in seeing this to some form of closure in this CF?

cheers ./daniel

Commits

  1. Revert pg_relation_check_pages()

  2. Fix incorrect placement of pfree() in pg_relation_check_pages()

  3. Add pg_relation_check_pages() to check on-disk pages of a relation

  4. Add CheckBuffer() to check on-disk pages without shared buffer loading

  5. Extend amcheck to check heap pages.