Horton

Re: [PATCH] Do not use StdRdOptions in Access Methods

Dent John <denty@qqdd.eu>

View thread View on postgr.es
From: Dent John <denty@QQdd.eu>
To: Nikolay Shaplov <dhyan@nataraj.su>
Cc: Thomas Munro <thomas.munro@gmail.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, "Iwata, Aya" <iwata.aya@jp.fujitsu.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Dmitry Dolgov <9erthalion6@gmail.com>, Michael Paquier <michael@paquier.xyz>
Date: 2019-10-09T19:26:14Z
Lists: pgsql-hackers 
> On 8 Oct 2019, at 11:33, Nikolay Shaplov <dhyan@nataraj.su> wrote:
> 
> Whoa-whoa!
> 
> I am not inventing something new here. Same code is already used in brin 
> (brin.c:820), gin (ginutils.c:602) and gist (gistutils.c:909) indexes. I've 
> just copied the idea, to do all index code uniform.
> 
> This does not mean that these code can't be improved, but as far as I can 
> guess it is better to do it in small steps, first make option code uniform, and 
> then improve all of it this way or another...

I didn’t spot it was an existing pattern.

And I agree — making the code uniform will make it easier to evolve in future.

Gets my vote.

denty.

Commits

  1. Refactor reloption handling for index AMs in-core

  2. Cleanup code in reloptions.h regarding reloption handling

  3. Refactor code building relation options

  4. Add some assertions to view reloption macros