Re: [Proposal] Global temporary tables

曾文旌 (义从) <wenjing.zwj@alibaba-inc.com>

From: 曾文旌 <wenjing.zwj@alibaba-inc.com>
To: tushar <tushar.ahuja@enterprisedb.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Prabhat Sahu <prabhat.sahu@enterprisedb.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, Konstantin Knizhnik <k.knizhnik@postgrespro.ru>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, "蔡松露(子嘉)" <zijia@taobao.com>, "Cai, Le" <le.cai@alibaba-inc.com>, "萧少聪(铁庵)" <shaocong.xsc@alibaba-inc.com>
Date: 2020-04-17T09:14:44Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. PageAddItemExtended(): Add LP_UNUSED assertion.

  2. Remove temporary files after backend crash

  3. Fix comment in indexing.c

  4. Fix failure to ignore leftover temp tables after a server crash.


> 2020年4月13日 下午6:32,tushar <tushar.ahuja@enterprisedb.com> 写道:
> 
> On 4/9/20 6:26 PM, 曾文旌 wrote:
>>> On 4/7/20 2:27 PM, 曾文旌 wrote:
>>>> Vacuum full GTT, cluster GTT is already supported in global_temporary_table_v24-pg13.patch.
>>> Here , it is skipping GTT
>>> 
>>> postgres=# \c foo
>>> You are now connected to database "foo" as user "tushar".
>>> foo=# create global temporary table  g123( c1 int) ;
>>> CREATE TABLE
>>> foo=# \q
>>> [tushar@localhost bin]$ ./vacuumdb --full  foo
>>> vacuumdb: vacuuming database "foo"
>>> WARNING:  skipping vacuum global temp table "g123" because storage is not initialized for current session
>> The message was inappropriate at some point, so I removed it.
>> 
> Thanks Wenjing. Please see -if this below behavior is correct 
> 
> X terminal -
> 
> postgres=# create global temp table foo1(n int);
> CREATE TABLE
> postgres=# insert into foo1 values (generate_series(1,10));
> INSERT 0 10
> postgres=# vacuum full ;
> VACUUM
> 
> Y Terminal - 
> 
> [tushar@localhost bin]$ ./vacuumdb -f  postgres
> vacuumdb: vacuuming database "postgres"
> WARNING:  global temp table oldest relfrozenxid 3276 is the oldest in the entire db
> DETAIL:  The oldest relfrozenxid in pg_class is 3277
> HINT:  If they differ greatly, please consider cleaning up the data in global temp table.
> WARNING:  global temp table oldest relfrozenxid 3276 is the oldest in the entire db
> DETAIL:  The oldest relfrozenxid in pg_class is 3277
> HINT:  If they differ greatly, please consider cleaning up the data in global temp table.
> 
I improved the logic of the warning message so that when the gap between relfrozenxid of GTT is small,
it will no longer be alarmed message.



Wenjing




> 
> -- 
> regards,tushar
> EnterpriseDB  https://www.enterprisedb.com/ <https://www.enterprisedb.com/>
> The Enterprise PostgreSQL Company