Re: On non-Windows, hard depend on uselocale(3)

Tristan Partin <tristan@partin.io>

From: "Tristan Partin" <tristan@partin.io>
To: "Thomas Munro" <thomas.munro@gmail.com>, "Tom Lane" <tgl@sss.pgh.pa.us>
Cc: "pgsql-hackers" <pgsql-hackers@postgresql.org>
Date: 2024-08-13T23:17:31Z
Lists: pgsql-hackers

Attachments

Hey Thomas,

Thanks for picking this up. I think your patch looks really good. Are 
you familiar with gcc's function poisoning?

	#include <stdio.h>
	#pragma GCC poison puts
	
	int main(){
	#pragma GCC bless begin puts
	    puts("a");
	#pragma GCC bless end puts
	}

I wonder if we could use function poisoning to our advantage. For 
instance in ecpg, it looks like you got all of the strtod() invocations 
and replaced them with strtod_l(). Here is a patch with an example of 
what I'm talking about.

-- 
Tristan Partin
Neon (https://neon.tech)