Horton

Re: [sqlsmith] Planner crash on foreign table join

Mark Dilger <hornschnorter@gmail.com>

View thread View on postgr.es
From: Mark Dilger <hornschnorter@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>, Andrew Gierth <andrew@tao11.riddles.org.uk>, Andreas Seltenreich <seltenreich@gmx.de>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Simon Riggs <simon@2ndquadrant.com>
Date: 2017-04-09T02:51:29Z
Lists: pgsql-hackers 
> On Apr 8, 2017, at 7:41 PM, Mark Dilger <hornschnorter@gmail.com> wrote:
> 
> 
>> On Apr 8, 2017, at 7:35 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> 
>> Mark Dilger <hornschnorter@gmail.com> writes:
>>> This is very near where the original crash reported in this thread was crashing, probably only
>>> different due to the extra lines of Assert that were added.  Am I missing some portion of the
>>> fix that you are testing?  I have only applied the patch that Tom included in the previous email.
>> 
>> No, that was the whole patch --- but did you do a full "make clean" and
>> rebuild?  The patch changed NodeTag numbers which would affect the whole
>> tree.
> 
> <snip>

> I'm going to pull completely fresh sources and reapply and retest, though you are welcome
> to review my patch while I do that.

That fixed it.  Thanks.

Commits

  1. Improve castNode notation by introducing list-extraction-specific variants.

  2. Clean up bugs in clause_selectivity() cleanup.

  3. Add newly-symlinked files to "make clean" target.

  4. Reset API of clause_selectivity()