Re: Meson far from ready on Windows
Tristan Partin <tristan@partin.io>
From: "Tristan Partin" <tristan@partin.io>
To: "Andres Freund" <andres@anarazel.de>, "Dave Page" <dpage@pgadmin.org>
Cc: "Nazir Bilal Yavuz" <byavuz81@gmail.com>, "PostgreSQL Developers"
<pgsql-hackers@lists.postgresql.org>
Date: 2024-07-16T20:53:45Z
Lists: pgsql-hackers
> From 9f7c96dfab4d807e668c9d32b44db5f4ff122e15 Mon Sep 17 00:00:00 2001 > From: Andres Freund <andres@anarazel.de> > Date: Mon, 8 Jul 2024 15:55:56 -0700 > Subject: [PATCH v2 02/10] Don't define HAVE_[GSSAPI_]GSSAPI_EXT_H > > The check for gssapi_ext.h was added in f7431bca8b0. As we require > gssapi_ext.h to be present, there's no point in defining symbols for the > header presence. > > While at it, use cc.has_header() instead of cc.check_header(), that's a bit > cheaper and it seems improbably that gssapi.h would compile while gssapi_ext.h > would not. improbable Other than that, it looks pretty solid. Looks like we could help future us out by teaching compiler.find_library() to take a list of names to look at similar to how dependency() works now. Reviewed-by: Tristan Partin <tristan@partin.io> -- Tristan Partin Neon (https://neon.tech)