Horton
Menu

Re: psql not responding to SIGINT upon db reconnection

Tristan Partin <tristan@neon.tech>

View thread
From: "Tristan Partin" <tristan@neon.tech>
To: "Jelte Fennema-Nio" <postgres@jeltef.nl>, "Robert Haas" <robertmhaas@gmail.com>
Cc: "Heikki Linnakangas" <hlinnaka@iki.fi>, "Tom Lane" <tgl@sss.pgh.pa.us>, <pgsql-hackers@postgresql.org>, "Shlok Kyal" <shlok.kyal.oss@gmail.com>
Date: 2024-04-03T14:20:36Z
Lists: pgsql-hackers 
On Wed Apr 3, 2024 at 8:32 AM CDT, Jelte Fennema-Nio wrote:
> On Tue, 2 Apr 2024 at 16:33, Robert Haas <robertmhaas@gmail.com> wrote:
> > Committed it, I did. My thanks for working on this issue, I extend.
>
> Looking at the committed version of this patch, the pg_unreachable
> calls seemed weird to me. 1 is actually incorrect, thus possibly
> resulting in undefined behaviour. And for the other call an imho
> better fix would be to remove the now 21 year unused enum variant,
> instead of introducing its only reference in the whole codebase.
>
> Attached are two trivial patches, feel free to remove both of the
> pg_unreachable calls.

Patches look good. Sorry about causing you to do some work.

-- 
Tristan Partin
Neon (https://neon.tech)

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix old, misleading comment for PGRES_POLLING_ACTIVE.

  2. Remove reachable call to pg_unreachable().

  3. Allow SIGINT to cancel psql database reconnections.

  4. Expose PQsocketPoll via libpq

  5. Fix query cancellation handling in psql